fix: retire the last @test_broken (main is red); land DB-6 docs + STATE refresh - #87
Conversation
… merge main is red: KnotTheory.jl#52 merged the link canonicalisation, so the BR-5 crossing-order marker reports "Unexpected Pass" — a hard error, and the signal the marker existed to produce. #85 and #86 were merged before these three changes were pushed, so they did not travel with them. 1. server/test_br5_fuzz.jl — marker restored to a plain @test. Measured against KnotTheory main after #52: 0 mismatches over 200 trials, links and knots alike (was 11/200, every one a multi-component link). quandledb now carries NO @test_broken markers; every marker this campaign added was retired by the upstream fix it tracked. 2. docs/db-6-explain-strategy.md — the document said "Phase A landed 2026-06-01" while issue #34's Phase A had never been built. Both were true of DIFFERENT surfaces, and conflating them is what made #34 look closable: SQL-side EXPLAIN QUERY PLAN over read-path SQL landed 2026-06-01 KRL-side explain keyword + structured plan landed 2026-07-28 Now names both and documents the KRL surface: syntax, plan shape, why explain is its own statement type, why selectivity is a labelled stub guarded by plan_is_costed(), why the indexed column list is deliberately short, and what Phase B needs. 3. .machine_readable/6a2/STATE.a2ml — last touched 2026-02-13, recording no milestones, no blockers and no next actions: the file agents read to orient themselves said nothing. Now carries measured state — phase testing, the DB-6/DB-3 milestone chain, four live issues (Guix gate, ruleset --admin, doc drift, ungated tiers) with evidence paths, ordered next actions with owners, and zero-known-broken-markers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review ✅ ApprovedRetires the final
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
1 participant
Summary
mainis red right now and this fixes it, plus lands two documentation changes that missed the #85/#86 merges (both PRs were merged before these commits were pushed).1. The last
@test_brokenretires — main is red until it doesKnotTheory.jl#52 merged the link canonicalisation, so the BR-5 crossing-order marker now reports "Unexpected Pass" — a hard error, and exactly the forcing signal the marker existed to produce.
Measured against KnotTheory
mainafter #52: 0 mismatches over 200 trials, links and knots alike (was 11/200, every one a multi-component link). Validated at CI's 50 trials — all four BR-5 testsets pass with no Broken column.quandledb now carries no
@test_brokenmarkers at all. Every marker this campaign added was retired by the upstream fix it was tracking, which is the mechanism working as intended.2.
docs/db-6-explain-strategy.md— reconciling two surfaces under one nameThe document said "Phase A landed 2026-06-01" while issue #34's Phase A had never been built. Both statements were true of different surfaces, and conflating them is what made #34 look closable:
EXPLAIN QUERY PLANover read-path SQL, HTTP endpointexplainkeyword + structured plan withindexed/selectivityNow names both explicitly and documents the KRL surface: syntax, plan shape, why
explainparses to its own statement type, why selectivity is a labelled stub guarded byplan_is_costed(), whyINDEXED_COLUMNSis deliberately short, and what Phase B actually needs (DB-3, #33).3.
.machine_readable/6a2/STATE.a2ml— the file agents read said nothingLast touched 2026-02-13, with
# No milestones recorded,# No blockers recorded,# No actions recorded. Now carries measured state: phasetesting, the DB-6/DB-3 milestone chain, the four live issues (Guix gate, ruleset--admin, doc drift, ungated Idris2/Zig/AffineScript tiers) each with an evidence path, ordered next actions with owners, andzero-known-broken-markers = true.last-resultis deliberatelywarn, notpass: every gate the repo owns is green, but the estate-wide Guix policy check is red and is not green-able here in good faith (seedev-notes/guix-policy-gate-advice-2026-07-28.md— the gate is presence-only, so a stubguix.scmwould buy green with a lie). Reported rather than suppressed.🤖 Generated with Claude Code